Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1: ctype_digit(): Argument of type int will be interpreted as string in the future #59

Closed
arokettu opened this issue Jan 13, 2022 · 1 comment · Fixed by #62
Closed

PHP 8.1: ctype_digit(): Argument of type int will be interpreted as string in the future #59

arokettu opened this issue Jan 13, 2022 · 1 comment · Fixed by #62

Comments

@arokettu
Copy link
Contributor

The check in if ($raw === '' || ctype_digit($raw)) { throws a deprecation warning in PHP 8.1:

ctype_digit(): Argument of type int will be interpreted as string in the future

There are 2 places: AbstractEscaper:119 and HtmlEscaper:68

I think the best solution is to cast $raw to string in the beginning
@harikt
Copy link
Member

harikt commented Jan 14, 2022

Thanks for the report. Once we get some time will look into it.

@arokettu arokettu mentioned this issue Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cast $raw to string to suppress ctype_digit deprecation
2 participants
@harikt @arokettu