Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on Application Developer notes/5.6 Bundling details Documentation page #764

Open
adriatic opened this issue Aug 11, 2017 · 0 comments

Comments

@adriatic
Copy link
Member

This is the first time I am going through this section, so I would rather make you aware of my finding than stepping in and making changes.

The sentence `The wrappers include only the Kendo files they need for that particular control to work is confusing me, as it does not clearly delineates the difference between a part of the bridge we call wrapper and the wrapped KendoUI SDK widget.

Let me make the reference to the beginning of the chapter 5.2 Loading a subset of controls:

You may often want to load only a subset of the components that KendoUI bridge provides. Instead of the requirement to load them all at the bootstrap time - controlled by the following code in main.js class:

Here you explain how to differentiate between loading the "full bridge" (all wrappers)

.plugin('aurelia-kendoui-bridge', kendo => kendo.pro())

and loading the subset of bridge's wrappers

.plugin('aurelia-kendoui-bridge', kendo => kendo.kendoButton().kendoGrid())

There is no indication in this text that the user has to make two decisions which need to be mutually consistent:

  1. which widgets from KendoUI SDK to load
  2. which bridge wrappers to load

where the additional problem is that these decisions are made at different locations in the application (main.js for wrappers for example and index.html using script tages; these are not the only two locations by the way)

Summary

The two chapters - 5.2 Loading a subset of controls and 5.6 Bundling details need to be referencing each other explaining this situation, or even better this "situation" should be explained in its own chapter that could then be referenced from each of the above 2 chapters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant