Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

overrideContext <- might need to rename internals #94

Closed
vegarringdal opened this issue Nov 8, 2017 · 0 comments
Closed

overrideContext <- might need to rename internals #94

vegarringdal opened this issue Nov 8, 2017 · 0 comments

Comments

@vegarringdal
Copy link
Member

overrideContext

https://github.com/vegarringdal/vGrid/blob/dev-rebuild/src/grid/contextMenu.ts#L124-L133

Might need to rename some of the variables here, since it will be very easy to override by accident.
Since entire class is binded to the menu I need to consider prefixing evything with avg_

I need to look if I have this issue elsewhere too

Other option can be that I force user to define a object in class using the grrid, that way its harder to miss, and if component have many grids you wont crash

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant