feat(i18n): support for [text]

aurelia · Aug 27, 2019 · 2576139 · 2576139
1 parent 93ec221
commit 2576139
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/packages/__tests__/i18n/t/translation-integration.spec.ts b/packages/__tests__/i18n/t/translation-integration.spec.ts
@@ -264,6 +264,19 @@ describe('translation-integration', function () {
     assertTextContent(host, `span#b`, translation.simple.text);
   });
 
+  it('works for textContent replacement with explicit [text] attribute - `t="[text]key"`', async function () {
+
+    @customElement({
+      name: 'app', template: `<span id='a' t='[text]simple.text'></span>`
+    })
+    class App { }
+
+    const host = DOM.createElement('app');
+    const { en } = await setup(host, new App());
+
+    assertTextContent(host, 'span', en.simple.text);
+  });
+
   it('works for innerHTML replacement - `t="[html]key"`', async function () {
 
     @customElement({

diff --git a/packages/i18n/src/t/translation-binding.ts b/packages/i18n/src/t/translation-binding.ts
@@ -43,6 +43,8 @@ interface ContentValue {
   append?: string;
 }
 
+const attributeAliases = new Map([['text', 'textContent'], ['html', 'innerHTML']]);
+
 @connectable()
 export class TranslationBinding implements IPartialConnectableBinding {
   public id!: number;
@@ -177,10 +179,14 @@ export class TranslationBinding implements IPartialConnectableBinding {
     if (attributes.length === 0) {
       attributes = this.target.tagName === 'IMG' ? ['src'] : ['textContent'];
     }
-    const htmlIndex = attributes.findIndex((attr) => attr === 'html');
-    if (htmlIndex > -1) {
-      attributes.splice(htmlIndex, 1, 'innerHTML');
+
+    for (const [alias, attribute] of attributeAliases) {
+      const aliasIndex = attributes.findIndex((attr) => attr === alias);
+      if (aliasIndex > -1) {
+        attributes.splice(aliasIndex, 1, attribute);
+      }
     }
+
     return attributes;
   }