Skip to content

Commit

Permalink
refactor(testing): adapt runtime refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
bigopon committed Nov 19, 2020
1 parent 86e8e9e commit 5d2b1f6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/testing/src/mocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export class MockBinding implements IConnectableBinding {
this.trace('handleChange', newValue, _previousValue, flags);
}

public observeProperty(flags: LifecycleFlags, obj: IIndexable, propertyName: string): void {
this.trace('observeProperty', flags, obj, propertyName);
public observeProperty(obj: IIndexable, propertyName: string): void {
this.trace('observeProperty', obj, propertyName);
}

public unobserve(all?: boolean): void {
Expand Down
4 changes: 2 additions & 2 deletions packages/testing/src/test-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,8 @@ export function createObserverLocator(containerOrLifecycle?: IContainer | ILifec

export function createScopeForTest(bindingContext: any = {}, parentBindingContext?: any, isComponentBoundary?: boolean): Scope {
return parentBindingContext
? Scope.fromParent(LF.none, Scope.create(LF.none, parentBindingContext), bindingContext)
: Scope.create(LF.none, bindingContext, OverrideContext.create(LF.none, bindingContext), isComponentBoundary);
? Scope.fromParent(Scope.create(parentBindingContext), bindingContext)
: Scope.create(bindingContext, OverrideContext.create(bindingContext), isComponentBoundary);
}

// export type CustomAttribute = Writable<IViewModel> & IComponentLifecycleMock;
Expand Down

0 comments on commit 5d2b1f6

Please sign in to comment.