refactor(bindings): use ??= instead

aurelia · Nov 26, 2020 · 830fdf5 · 830fdf5
1 parent 842ab26
commit 830fdf5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 17 deletions.
diff --git a/packages/runtime-html/src/binding/attribute.ts b/packages/runtime-html/src/binding/attribute.ts
@@ -134,10 +134,9 @@ export class AttributeBinding implements IPartialConnectableBinding {
       if (newValue !== this.value) {
         this.value = newValue;
         if (shouldQueueFlush) {
-          this.task?.cancel();
-          this.task = this.$platform.domWriteQueue.queueTask(() => {
+          this.task ??= this.$platform.domWriteQueue.queueTask(() => {
             if (this.isBound) {
-              interceptor.updateTarget(newValue, flags);
+              interceptor.updateTarget(this.value, flags);
             }
             this.task = null;
           }, taskOptions);

diff --git a/packages/runtime/src/binding/interpolation-binding.ts b/packages/runtime/src/binding/interpolation-binding.ts
@@ -86,12 +86,10 @@ export class InterpolationBinding implements IBinding {
     if (shouldQueueFlush) {
       // an optimization: only create & queue a task when there's NOT already a task queued
       // inside the lambda, use this.value instead of result, since it would always be the latest value
-      if (this.task == null) {
-        this.task = this.taskQueue.queueTask(() => {
-          targetObserver.setValue(this.value, flags, this.target, this.targetProperty);
-          this.task = null;
-        }, queueTaskOptions);
-      }
+      this.task ??= this.taskQueue.queueTask(() => {
+        targetObserver.setValue(this.value, flags, this.target, this.targetProperty);
+        this.task = null;
+      }, queueTaskOptions);
     } else {
       targetObserver.setValue(result, flags, this.target, this.targetProperty);
     }

diff --git a/packages/runtime/src/binding/property-binding.ts b/packages/runtime/src/binding/property-binding.ts
@@ -99,14 +99,12 @@ export class PropertyBinding implements IPartialConnectableBinding {
         if (shouldQueueFlush) {
           // an optimization: only create & queue a task when there's NOT already a task queued
           // inside the lambda, use this.value instead of result, since it would always be the latest value
-          if (this.task == null) {
-            this.task = this.taskQueue.queueTask(() => {
-              if (this.isBound) {
-                interceptor.updateTarget(this.value, flags);
-              }
-              this.task = null;
-            }, updateTaskOpts);
-          }
+          this.task ??= this.taskQueue.queueTask(() => {
+            if (this.isBound) {
+              interceptor.updateTarget(this.value, flags);
+            }
+            this.task = null;
+          }, updateTaskOpts);
         } else {
           interceptor.updateTarget(newValue, flags);
         }