Skip to content

Commit

Permalink
feat(router): fix issue with scopeContext
Browse files Browse the repository at this point in the history
  • Loading branch information
jwx committed Jul 7, 2019
1 parent 547a5eb commit 87c00bc
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/router/src/scope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,9 @@ export class Scope {
let viewport: Viewport = this.parent.closestViewport((this.element as any).$controller.parent);
while (viewport && viewport.owningScope === this.parent) {
parents.unshift(viewport.description(full));
// TODO: Change this to controller implementation?
viewport = this.closestViewport((viewport.context.get(IContainer) as ChildContainer).parent);
// TODO: Write thorough tests for this!
viewport = this.closestViewport((viewport.element as any).$controller.parent);
// viewport = this.closestViewport((viewport.context.get(IContainer) as ChildContainer).parent);
}
parents.unshift(this.parent.scopeContext(full));

Expand Down

0 comments on commit 87c00bc

Please sign in to comment.