Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all JIT attribute value parsing to the ExpressionParser #74

Closed
fkleuver opened this issue Aug 19, 2018 · 0 comments
Closed

Move all JIT attribute value parsing to the ExpressionParser #74

fkleuver opened this issue Aug 19, 2018 · 0 comments

Comments

@fkleuver
Copy link
Member

fkleuver commented Aug 19, 2018

  • Interpolation parsing currently happens in the TemplateCompiler. Moving this to the ExpressionParser allows interpolation expressions to be cached just like other expressions
  • Semicolon-separated custom attribute values are not being parsed yet. This should be done by the ExpressionParser.
  • Pass more context information (attribute type + binding command) to the ExpressionParser so it can make the right decisions about valid/invalid syntax.
  • Implement loose vs strict parsing mode, where strict mode will detect and throw errors as early as possible (e.g. if a two-way binding command has a non-assignable expression, warn in loose mode and throw in strict mode?) (not appropriate for this scope)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant