fix(parser): throw on unterminated quote instead of infinite loop

aurelia · Oct 30, 2018 · 4907f38 · 4907f38
1 parent 3923e18
commit 4907f38
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/parser.js b/src/parser.js
@@ -472,7 +472,7 @@ export class ParserImplementation {
 
         buffer.push(fromCharCode(unescaped));
         marker = this.idx;
-      } else if (this.ch === /*EOF*/0) {
+      } else if (this.ch === /*EOF*/0 || this.idx >= this.len) {
         this.err('Unterminated quote');
       } else {
         this.next();

diff --git a/test/parser.spec.js b/test/parser.spec.js
@@ -661,6 +661,23 @@ describe('Parser', () => {
   });
 
   describe('should not parse', () => {
+    describe('LiteralString with unterminated quote', () => {
+      const expressions = [
+        '\'a',
+        '\'',
+        'a\'',
+        '"a',
+        '"',
+        'a"'
+      ];
+
+      for (const expr of expressions) {
+        it(expr, () => {
+          _verifyError(expr, 'Unterminated quote');
+        });
+      }
+    });
+
     describe('LiteralObject with computed property', () => {
       const expressions = [
         '{ []: "foo" }',