Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling #31

Closed
Mordred opened this issue Sep 20, 2015 · 4 comments · Fixed by #36
Closed

Scrolling #31

Mordred opened this issue Sep 20, 2015 · 4 comments · Fixed by #36

Comments

@Mordred
Copy link
Contributor

Mordred commented Sep 20, 2015

Bootstrap modal is setting .modal-open class on the body element to set overflow: hidden. Can you add this behaviour so that scrolling will not scroll page under dialog?

@Mordred
Copy link
Contributor Author

Mordred commented Sep 23, 2015

Can you release this?

@plwalters
Copy link
Contributor

@Mordred I saw an issue on the dialog and realized this commit broke the styling on the modal. It is now 100% width of the screen. Are you sure that the PR was working properly? I'm going to have to back it out I think. You can see the issue by cloning the repository and running the sample app with gulp watch

@Mordred
Copy link
Contributor Author

Mordred commented Oct 6, 2015

@PWKad Can you post some images? Because I don't know what you mean. I've tried your sample it using Chrome and modal has only 300px. What browser are you using?

@plwalters
Copy link
Contributor

Sorry I think the issue was the Chrome styling for a native dialog element caused the math introduced in this PR to work but when I switched the name it went crazy. Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants