-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Official docker image on docker hub #8
Comments
I'm down with this idea. We can use the same image for our own CI/CD. The one we are currently using for vCurrent CI/CD can be found here FROM circleci/node:8.11.3-browsers
RUN sudo chown -R circleci /usr/local
RUN npm i -g npm istanbul http-server codecov protractor gulp jspm && \
webdriver-manager update
RUN sudo apt-get update && \
sudo apt-get install -y wget
RUN wget -O ~/ChromeSetup.deb "https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb" && \
sudo dpkg -i ~/ChromeSetup.deb; sudo apt-get -fy install && \
rm ~/ChromeSetup.deb Of what would you like to have different versions installed, though? The cli? How about different versions of node, webpack and whatnot? I'm a bit worried about a potential explosion of combinations of versions here. We do need a solid, justified decision on this that makes an acceptable trade-off between flexibility and maintainability. |
Please correct me if I am wrong 🙏
I couldn't agree more with what you are worried about, and think there is a misunderstanding of my statement. I did not mean to have a docker file per webpack versions or any other dependencies.
Exactly, what I meant is to have a docker image in which we have what you just have here + The only thing by my suggestion is that we could have a docker image with different tags, based on the version of I think this brings better support for dockerizing aurelia apps and does not bring that much of maintainability. |
Alright, understood. What do you think about this existing docker image that we already have for CircleCI? We could add aurelia-cli to that, do some automated tagging magic to get a version per aurelia-cli version and we would essentially be done, right? |
Yes, It looks to be fine, just need the aurelia-cli and tagging; however, |
Absolutely! So for any viewers: we just discussed this on discord and it turns out there's a little bit more to it (mostly from an automation point of view). We agreed that @shahabganji will open a PR and take things from there. |
I think it would be beneficial for the whole community to have an official
Aurelia
docker image in which some services likeaurelia-cli
are installed by default.This will help them to be able to have multiple images with different CLI version, side by side, and it could help them to facilitate the CI/CD pipeline by focusing on their application's requirements for dockerization rather than thinking of which aurelia-cli or compatible versions of its dependencies to be installed.
A simple suggested docker image could be built using the following:
Then we could have different versions, with different configurations pre-installed so that developers are able to test their application with those configurations.
/cc @EisenbergEffect
The text was updated successfully, but these errors were encountered: