Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined interface in typescript definition #15

Closed
sujesharukil opened this issue Aug 14, 2015 · 5 comments
Closed

undefined interface in typescript definition #15

sujesharukil opened this issue Aug 14, 2015 · 5 comments

Comments

@sujesharukil
Copy link

Aurelia-loader-default.d.ts has DefaultLoader class.loadTemplate function return a Promise.

TemplateRegistryEntry is showing up as undefined. Don't know where this is defined.

@stefan505
Copy link

Also, there's two typos namely Proimise<any> and Promse<any[]>.

@paulvanbladel
Copy link

would be happy to do a PR for fixing this, but of course the .d.ts file seems to be generated.
How can we help here? Would be nice to get a pointer on how this file is currently generated.

The full file should be:

declare module 'aurelia-loader-default' {
  import { Origin }  from 'aurelia-metadata';
  import { Loader, TemplateRegistryEntry }  from 'aurelia-loader';
  export class DefaultLoader extends Loader {
    constructor();
    loadModule(id: string): Promise<any>;
    loadAllModules(ids: string[]): Promise<any[]>;
    loadTemplate(url: string): Promise<TemplateRegistryEntry>;
    loadText(url: string): Promise<string>;
  }
}

@JeroenVinke
Copy link
Collaborator

There already are PR's for the promise typo's : #14, #19, #18. I think that the wait is for a release of the babel-dts-generator which fixes the return type issue (YoloDev/babel-dts-generator#26)

@EisenbergEffect
Copy link
Contributor

The PRs will be processed today and we'll get a release out asap. Apologies for the delay in this. Hang tight and there will likely be a new release tonight or tomorrow morning.

@EisenbergEffect
Copy link
Contributor

Fixed in a previous release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants