Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol is not defined in Firefox 35 #53

Closed
unional opened this issue Jul 28, 2017 · 6 comments
Closed

Symbol is not defined in Firefox 35 #53

unional opened this issue Jul 28, 2017 · 6 comments
Labels

Comments

@unional
Copy link

unional commented Jul 28, 2017

I'm submitting a bug report

  • Library Version:
    1.2.1

Please tell us about your environment:

  • Operating System:
    Linux

  • Browser:
    Firefox 35

  • Language:
    all

Current behavior:
Symbol is not defined at https://github.com/aurelia/polyfills/blob/master/dist/aurelia-polyfills.js#L277
src: https://github.com/aurelia/polyfills/blob/master/src/symbol.js#L277

Expected/desired behavior:
It should be polyfilled.

@gheoan
Copy link
Contributor

gheoan commented Jul 29, 2017

It is polyfilled by the code you linked.

@unional
Copy link
Author

unional commented Jul 29, 2017

The line I linked throw exception Symbol is not defined on FireFox 35.
And also, if you look into the code. It does not use the pass in param S.

The issue is accessing Symbol immediately throws. Need to be something like window['Symbol']

@Alexander-Taran
Copy link

An firefox 35 is special how?
I thought the were evergreen.

@unional
Copy link
Author

unional commented Mar 25, 2018

It's about the range of browsers supported. Somewhere in between, this code doesn't work.

See https://stackoverflow.com/questions/45453374/should-in-between-browser-compatibility-issue-be-handled for more details.

@Alexander-Taran
Copy link

Ok.. so you are the guy who's been asked to support FF35..
As in answer to your question on SO - say no.
IE is different in a way. For corporations that buit internal software for IE6.
Firefox.. no reason to support that far back.

@EisenbergEffect
Copy link
Contributor

Closing for now. Happy to accept a PR if there's a legitimate fix and it's still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants