Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

typescript errors #867

Closed
paul23-git opened this issue Nov 6, 2017 · 10 comments
Closed

typescript errors #867

paul23-git opened this issue Nov 6, 2017 · 10 comments

Comments

@paul23-git
Copy link

I'm submitting a bug report

  • Aurelia Skeleton Version
    skeleton-typescript
  • Framework Version:
    1.1.2

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    8.9.0

  • NPM Version:
    5.5.1
  • **JSPM **
    JSPM 0.16.53
  • Browser:
    all

  • Language:
    TypeScript

Current behavior:
When following the given readme for skeleton-typescript after trying to execute the test-skeleton. (installing etc works). The following errors (in part) occur:

X:/node_modules/typescript/lib/lib.dom.d.ts(3913,11): error TS2300: Duplicate identifier 'Headers'.
[03:05:04] gulp-notify: [Error running Gulp] Error: X:/node_modules/typescript/lib/lib.dom.d.ts(3913,11): error TS2300: Duplicate identifier 'Headers'.
X:/node_modules/typescript/lib/lib.dom.d.ts(3922,13): error TS2300: Duplicate identifier 'Headers'.
[03:05:04] gulp-notify: [Error running Gulp] Error: X:/node_modules/typescript/lib/lib.dom.d.ts(3922,13): error TS2300: Duplicate identifier 'Headers'.
X:/node_modules/typescript/lib/lib.dom.d.ts(9227,11): error TS2300: Duplicate identifier 'Request'.
[03:05:04] gulp-notify: [Error running Gulp] Error: X:/node_modules/typescript/lib/lib.dom.d.ts(9227,11): error TS2300: Duplicate identifier 'Request'.
X:/node_modules/typescript/lib/lib.dom.d.ts(9244,13): error TS2300: Duplicate identifier 'Request'.
[03:05:04] gulp-notify: [Error running Gulp] Error: X:/node_modules/typescript/lib/lib.dom.d.ts(9244,13): error TS2300: Duplicate identifier 'Request'.

...
typings\globals\whatwg-fetch\index.d.ts(3,15): error TS2300: Duplicate identifier 'Request'.
[03:16:56] gulp-notify: [Error running Gulp] Error: typings\globals\whatwg-fetch\index.d.ts(3,15): error TS2300: Duplicate identifier 'Request'.
typings\globals\whatwg-fetch\index.d.ts(41,15): error TS2300: Duplicate identifier 'Headers'.
[03:16:56] gulp-notify: [Error running Gulp] Error: typings\globals\whatwg-fetch\index.d.ts(41,15): error TS2300: Duplicate identifier 'Headers'.

I've truncated a lot of similar errors ("duplicate identifier"), the X:/ is the location where I've created the project with the skeletal build.

I've tried following the solutions given #775 But those don't seem to solve the problem (npm uninstall @types\whatwg-fetch) - I presume this is due to the skeletal builds not using @types declaration but rather the deprecated typings module?

Expected/desired behavior:

I expect the skeletal builds to fully work with the newest libraries of aurelia/typescript - since they're created for those?

@joelowrance
Copy link

joelowrance commented Jan 18, 2018

Seeing the same issue. Any updates on this? (Or anything I can do to help?)

@joelowrance
Copy link

Based on a similar issue found here https://github.com/DefinitelyTyped/DefinitelyTyped/issues/16509, adding "skipLibCheck": true to the tsconfig,json file at least works around this.

@Alexander-Taran
Copy link

Cloned repo.
Changed directory to skeleton-typescript
executed yarn
executed yarn jspm install
executed yarn gulp watch

no problems found.

git clean -d -x -f

npm install
.\node_modules.bin\jspm install
.\node_modules.bin\gulp watch

no problems found

node -v
v8.9.4

npm --version
5.6.0

Can you retry?
Oh.. I did it with master.. will have to retry with latest release

@joelowrance
Copy link

@Alexander-Taran I have retried against master and everything is fine. Seems to be an issue only with the released version (which is the recommended download in the docs).

@Alexander-Taran
Copy link

Now this transforms into a huge task (-:
Check all other skeletons on master.
Update to webpack 4
Check and update all documentation referencing skeletons
and release

help_needed

@paul23-git
Copy link
Author

This problem is indeed with the "archive download" from the documentation. ("start here").

@Alexander-Taran
Copy link

Alexander-Taran commented Mar 24, 2018

@pulli23 what documentation is that?
could not find it

@plwalters
Copy link
Contributor

The TypeScript skeleton has another issue it seems -

// Error: (SystemJS) Cannot read property 'base64encode' of undefined

When cloning a clean skeleton and installing fresh deps from npm and jspm this error is thrown. Trying to figure out the cause now but I think the tests are broken on latest release.

@plwalters
Copy link
Contributor

Disregard looks like it is a known TS issue - microsoft/TypeScript#24638 - that has a fix about to release.

@Alexander-Taran
Copy link

@3cp I think we can close this..

@bigopon bigopon closed this as completed Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants