-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish new version (ie. from 0.9.25 to 0.9.26) #191
Comments
Just noticed this; I've added
|
Thanks! I appreciate you taking the time to do this in your own time! |
@EisenbergEffect Are we able to get this published soon? Just an ETA so I know when to expect this to be updated will make me happy :) |
Just got internet back after snow storm took it out for a day and a half :) I'm looking into this now. Might take a day or two since I need to look into details a bit more and see if there's anything special in the publish process. Thanks for your patience @silbinarywolf |
Ah thats rough! We've had flooding / heavy rain down here too lately! |
Sadly, this repo doesn't build 😢I'm going to have to dig in and try to find out what's going on. Might take a bit of time. |
I've pushed a new version to master that updates some dependencies. The current issue appears to be that the TypeScript compiler APIs have changed. Since I'm less familiar with the internal AST APIs, I'm not sure what the correct way is to convert from the old code to the new code. The errors are in one file: |
That's essentially the issue I hit while trying to update this. The AST APIs have all changed. |
I'm hoping the fix is obvious to @fkleuver :) If not or if he doesn't get around to it, then I'll plan to tackle this in a few days. |
It appeared to be a fairly straight-forward fix (that is, if things actually still work). See #192 |
Thanks for taking time to look into this @fkleuver I was going to sit down today and figure it out...so your timing is impeccable 🤣 @silbinarywolf Can you try this out in your app and see if it gets you going again? |
Not sure what you mean by "get us going again"? The current tagged version is functioning OK, it'll just be painful if somebody on my team hits the bug I fixed in my PR from a couple of months ago :) ie. unclosed HTML tags. |
I mainly meant, can you confirm if what's in master now works for you, now that we've updated the compiler and got it building again. |
Yep sure. I'll set aside some time this week to do this :) |
Awesome. Thank you @silbinarywolf ! |
Its working fine for my use-case! However it's worth noting that we currently don't have EDIT: cc @EisenbergEffect |
Excellent. Thanks! |
I published 0.10.0. |
@EisenbergEffect Thanks! Perhaps tag the Git repo with that version too :) |
Yep, that's next :) |
As per this PR comment:
#189 (comment)
Waiting on @MeirionHughes to reply back and give @AureliaEffect npm publishing rights.
cc @EisenbergEffect
I wanted to create an explicit issue that's open so other users can be made aware of what we're waiting on.
The text was updated successfully, but these errors were encountered: