Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible problem with @children depending on location of <content> #250

Closed
csaloio opened this issue Jan 20, 2016 · 6 comments
Closed

Possible problem with @children depending on location of <content> #250

csaloio opened this issue Jan 20, 2016 · 6 comments
Assignees
Labels

Comments

@csaloio
Copy link

csaloio commented Jan 20, 2016

Please see this plunker:
http://plnkr.co/edit/0yEcM9eDlyaR5LnsjYZg?p=preview

If <content> is not nested the array created by @children is correct. WHen it is nested the array is always empty.

@EisenbergEffect
Copy link
Contributor

Thanks for reporting this! We need to do some improvements how how @children works internally and those should fix this issue.

@charlespockert
Copy link

Was wondering when this would be fixed. Not a massive issue for me but it saves me having to use an extra div every time I want an instance of a certain control
#218

@EisenbergEffect
Copy link
Contributor

I'm hoping to get it in the next iteration. It's been bugging me so I want to get it addressed sooner than later. Maybe next week?

@MikaelPorttila
Copy link

Any updates on this issue?

@EisenbergEffect
Copy link
Contributor

Quick update on this. We are working on a solution. However, the fix is probably going to have to wait until we update to Shadow DOM v1 because the implementation details are strongly connected. We'll do a bit more research this week and see if there's a way we can address it before then.

@EisenbergEffect
Copy link
Contributor

This issue is now fixed in our shadow dom v1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants