Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure, IOP_GROUP_TONE undefined in test_filmicrgb.c #208

Open
podiki opened this issue Sep 7, 2023 · 1 comment
Open

Build failure, IOP_GROUP_TONE undefined in test_filmicrgb.c #208

podiki opened this issue Sep 7, 2023 · 1 comment
Labels
bug priority: low Affects optional and niche functionnalities

Comments

@podiki
Copy link

podiki commented Sep 7, 2023

Building from current commit, eb70788, I get the following failure in building

/tmp/guix-build-ansel-4.0.0-1.eb70788.drv-0/source/src/tests/unittests/iop/test_filmicrgb.c:72:37: fatal error: use of undeclared identifier 'IOP_GROUP_TONE'
  assert_int_equal(default_group(), IOP_GROUP_TONE | IOP_GROUP_TECHNICAL);
                                    ^
1 error generated.

I believe the culprit is src/common/iop_group.c being removed in d813577 I'm building on Guix (essentially same formula as building Darktable). In Guix we always try to build and run tests, so we enable that here with -DBUILD_TESTING=On. Removing that flag allows the build to succeed, but, of course, at the expense of no longer having the tests to run.

@Jiyone Jiyone added bug priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability difficulty: easy and removed difficulty: easy labels Sep 8, 2023
@Jiyone Jiyone closed this as completed Nov 12, 2023
@aurelienpierre aurelienpierre added priority: low Affects optional and niche functionnalities and removed priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability labels Jan 2, 2024
@aurelienpierre
Copy link
Collaborator

The tests do basically nothing and the filmic unit tests are basically just an example of how to use tests. The integration tests have "natural" variations (delta E errors) between OpenCL and plain C pathes, and between compiler optimizations, that make them really hard to read when something seemingly fails. I suggest you just disable tests, nothing meaningful is to be found there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority: low Affects optional and niche functionnalities
Projects
None yet
Development

No branches or pull requests

3 participants