Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to django-allauth? #2

Open
wetneb opened this issue Apr 25, 2018 · 1 comment
Open

PR to django-allauth? #2

wetneb opened this issue Apr 25, 2018 · 1 comment

Comments

@wetneb
Copy link

wetneb commented Apr 25, 2018

Hi! Thanks for this!
Have you considered submitting this to django-allauth as a PR?
@aureplop
Copy link
Owner

Hi! My pleasure ;-)
It could be ! Could ask for @pennersr's POV ?

For the base, my opinion is it may be a good idea.

For the message part, but I think it's less important and clear. It could be more opened to be useful with any kind of provider. It could be discussed further in another ticket (here or there)...
Maybe an how-to in django-allauth's doc would be sufficent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wetneb @aureplop