Feat: give output as json from abi-based methods #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows nice output when calling from the NEAR CLI. Example:
This feature is implemented by having environment functions like
value_return
andrevert
only update the internal EVM state (setting the exit status and return data), not call any external exit methods (likeprocess::exit
, or NEAR's host functions). Instead, the exit calls happen as part of a new function calledpost_exec
. This gives a chance for the return data to be re-encoded from ABI into JSON before the value is returned.The main files to focus on in the review are:
compiler.rs
,api.rs
andencode.rs
. Note that the code for decoding JSON into ABI input was simply moved fromapi.rs
todecode.rs
with no changes.