Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick search to zone records tabs #250

Closed
mikat-gh opened this issue Nov 8, 2022 · 5 comments · Fixed by #253
Closed

Add quick search to zone records tabs #250

mikat-gh opened this issue Nov 8, 2022 · 5 comments · Fixed by #253

Comments

@mikat-gh
Copy link

mikat-gh commented Nov 8, 2022

Hi,

Can we have quick search in the zone records and managed records tabs?

There is quick search in the records page, but then I need to filter by zone first. Going via the zone page is more logical way for me.

@peteeckel
Copy link
Contributor

Hi @mikat-gh, I'll look into it ... should be possible, I think.

@peteeckel
Copy link
Contributor

peteeckel commented Nov 8, 2022

Hi, I had a look at this now.

The Quick Search function is buried somewhere in the javascript innards of NetBox (a good starting point is netbox/templates/inc/table_controls_htmx.html). It's probably possible to extend the ZoneRecordListView and ZoneManagedRecordListView and the templates zone_record.html and zone_managed_record.html of NetBox DNS so that the Quick Search field magically appears and works (I only managed the former :-)), but there's too much JavaScript involved for my taste, so I'm out.

If someone would like to pick this up it would be highly welcome - I would like to learn something and the functionality would be useful. But without someone joining in and helping I don't see a chance we get it in the forseeable future.

@peteeckel
Copy link
Contributor

peteeckel commented Nov 21, 2022

Good news, @mikat-gh!

The version that will support NetBox 3.4 will also have Quick Search in zone record/managed record lists. I could probably do it earlier as well, but I think it won't take too long until NetBox 3.4 will be released.

[Edit: No, I can't backport it, as it depends on the ViewTab concept that will be introduced in NetBox 3.4]

@mikat-gh
Copy link
Author

Great, thanks @peteeckel!

We can wait for this one, but is there a release planned with current fixes in master before requiring NetBox 3.4? Probably need to hold until 3.4.1 or .2 before upgrading production.

@peteeckel
Copy link
Contributor

I guess that's a question for @hatsat32 ... I'm just a mere contributor, the release planning is not within my influence. Would make sense, though, before NetBox 3.4 comes out, as the release before that will probably be the last one compatible with NetBox 3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants