Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken uri.join #7

Open
evilj0e opened this issue Nov 28, 2016 · 1 comment
Open

broken uri.join #7

evilj0e opened this issue Nov 28, 2016 · 1 comment

Comments

@evilj0e
Copy link

evilj0e commented Nov 28, 2016

It breaks when you pass parts with protocol:

const url = uri.join('https://ya.ru', 'test', 'message');

In this case url should be https://ya.ru/test/message, but i've got https:/ya.ru/test/message.
It removes / from uri part.
@TimeRaider
Copy link
Contributor

it was not meant for that, use

'https://ya.ru/' + uri.join('test', 'message')'

@TimeRaider TimeRaider mentioned this issue Dec 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimeRaider @evilj0e