Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start and end time are required for CreateVideoStream endpoint but this is not being enforced #18

Open
scott97 opened this issue Jun 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@scott97
Copy link
Collaborator

scott97 commented Jun 14, 2023

The CreateVideoStream endpoint should be enforcing that requests contain valid JSON. However, this is not the case, requests omitting fields startTime or endTime are successful. We should expect that it return a status code of 400 and JSON: {"message": "invalid json in request"}

Request

POST http://localhost:3000/api/v1/videostreams HTTP/1.1
Content-Type: application/json

{
    "stream_url": "https://www.youtube.com/watch?v=abcdefghijk",
	"capturesource": 4677629739270144
}

Response

HTTP/1.1 200 OK
Date: Wed, 14 Jun 2023 02:04:11 GMT
Content-Type: application/json
Content-Length: 23
Connection: close

{
  "id": 6329105062559744
}
@scott97 scott97 added the bug Something isn't working label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant