Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unique prefix on config values #83

Open
10 tasks
aussig opened this issue Dec 30, 2022 · 0 comments
Open
10 tasks

Implement unique prefix on config values #83

aussig opened this issue Dec 30, 2022 · 0 comments
Labels
chore Internal tidy-up, refactor or other background task compliance Code quality, EDMC recommendations, or otherwise compliance-related in progress This issue is being worked on. Usually appropriate for long-term issues.,
Milestone
Backlog

Comments

@aussig
Copy link
Owner

aussig commented Dec 30, 2022 •
edited
Loading

Currently all config values are prefixed with X with isn't particularly unique or identifiable.

EDMC docs recommend that all plug-in config values are prefixed with a unique identifier.

So implement a one-off migration to store all config values prefixed with BGST_.

On load logic:

  1. Check for existence of BGST_ value first.
  2. If present, use it. If not present, look for equivalent X value.
  3. If present, use it, save to new BGST_ value and delete X value. If not present, use default value.
  • XShowZeroActivity
  • XAbbreviate
  • XSecondaryInf
  • XDiscordUsername
  • XEnableOverlay
  • XDiscordWebhook
  • XDiscordTWWebhook
  • XCurrentSystemID
  • XStationFaction
  • XStationType
@aussig aussig added the compliance Code quality, EDMC recommendations, or otherwise compliance-related label Dec 30, 2022
@aussig aussig added this to the Backlog milestone Dec 30, 2022
@aussig aussig added the chore Internal tidy-up, refactor or other background task label Jan 8, 2023
@aussig aussig added the in progress This issue is being worked on. Usually appropriate for long-term issues., label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Internal tidy-up, refactor or other background task compliance Code quality, EDMC recommendations, or otherwise compliance-related in progress This issue is being worked on. Usually appropriate for long-term issues.,
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@aussig