Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect race condition #6

Closed
epenet opened this issue Apr 11, 2023 · 0 comments · Fixed by #7
Closed

Disconnect race condition #6

epenet opened this issue Apr 11, 2023 · 0 comments · Fixed by #7
Assignees
@epenet
Labels
bug Something isn't working

Comments

@epenet
Copy link
Contributor

epenet commented Apr 11, 2023 •
edited

Describe the bug
There seems to be a race condition in the current disconnect logic.
self._is_manually_disconnecting is set to True, but when disconnected event comes through the reason is DEVICE

This results in unwanted reconnect attempts

To Reproduce
see home-assistant/core#90850

In particular https://github.com/home-assistant/core/actions/runs/4638938384/jobs/8209309875?pr=90850

Additional context
Add any other context about the problem here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epenet epenet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect reconnect in disconnect logic epenet/pysnooz
1 participant
@epenet