Pass a block to Sensor#when_received_data #28

Closed
pcasaretto opened this Issue Feb 14, 2013 · 3 comments

Projects

None yet

3 participants

@pcasaretto
Contributor

Hey,

I wanted to enable passing a block to Sensor#when_received_data and I was worried about mantaining backwards compatibility, but then I came across this commit ee67d3f .
Should I care about backwards compatibility here?
I actually have both versions ready.

@austinbv
Owner

The gem is new and < v1.0 so backwards compatibly is not huge to me.

@pcasaretto
Contributor

Cool. So design-wise, would you like for the method to handle both procs and blocks?
Personally, I would go with just blocks.

@austinbv
Owner

just blocks is fine. I don't know why I did procs to begin with...

If you wanna go ahead and add it go ahead and knock yourself out otherwise I will do it when I get a few minutes.

@vickash vickash closed this in 0adfb83 Feb 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment