Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a block to Sensor#when_received_data #28

Closed
pcasaretto opened this issue Feb 14, 2013 · 3 comments · Fixed by #29
Closed

Pass a block to Sensor#when_received_data #28

pcasaretto opened this issue Feb 14, 2013 · 3 comments · Fixed by #29

Comments

@pcasaretto
Copy link
Contributor

Hey,

I wanted to enable passing a block to Sensor#when_received_data and I was worried about mantaining backwards compatibility, but then I came across this commit ee67d3f .
Should I care about backwards compatibility here?
I actually have both versions ready.
@austinbv
Copy link
Owner

The gem is new and < v1.0 so backwards compatibly is not huge to me.

@pcasaretto
Copy link
Contributor Author

Cool. So design-wise, would you like for the method to handle both procs and blocks?
Personally, I would go with just blocks.

@austinbv
Copy link
Owner

just blocks is fine. I don't know why I did procs to begin with...

If you wanna go ahead and add it go ahead and knock yourself out otherwise I will do it when I get a few minutes.

@pcasaretto pcasaretto mentioned this issue Feb 22, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sensor accept blocks instead of procs pcasaretto/dino
3 participants
@austinbv @pcasaretto @vickash