Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y automated testing #79

Closed
2 tasks done
TheJaredWilcurt opened this issue May 19, 2020 · 2 comments · Fixed by #110
Closed
2 tasks done

A11y automated testing #79

TheJaredWilcurt opened this issue May 19, 2020 · 2 comments · Fixed by #110

Comments

@TheJaredWilcurt
Copy link
Contributor

TheJaredWilcurt commented May 19, 2020

  • ESlint-Plugin-Vue-A11y - This is a pretty easy win. Just a lint plugin to catch some simple stuff.
  • Pa11y - is a pretty good tool. It could test against the built docs pages for WCAG/Section 508. Would take a little more time to set up, but could then automate reports.
@AustinGil
Copy link
Owner

Yeah, this is a good idea. I've got some local a11y linters set up which catch stuff locally, but if more folks start contributing then integrated a11y linting on commit would be a good step, and then in CI/CD is even better.

Great idea!

@TheJaredWilcurt
Copy link
Contributor Author

TheJaredWilcurt commented May 19, 2020

I'm pretty strongly against tying anything into git hooks. It just breaks too many git GUI's, and it forces people with different workflows into something that may be inconvenient. Just having a CI run the check is fine. As long as you can't merge to master until those are fixed, it doesn't matter if it's done on every commit, or just once on the last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants