Getting a failure under node #23

csterritt · 2017-02-18T16:18:54Z

Hello,

Trying the fourth test function under node.

However, I'm compiling from ES6, so I've switched the functions to arrow functions:

import * as hamsters from 'hamsters.js'

//4 threads and let's aggregate our individual thread results into one final output
const pfunc = () => {
  const params = { 'array': [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] }
  hamsters.run(params, () => {
      const arr = params.array
      arr.forEach((item) => {
        rtn.data.push((item * 120) / 10)
      })
    },
    (output) => output,
    4, true)
}
const res = pfunc()
console.log("hamster res:", res)

This fails with the following error:

hamster res: undefined
/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:653
      self.rtn = {
      ^

ReferenceError: self is not defined
    at null._onTimeout (/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:653:7)
    at Timer.listOnTimeout (timers.js:92:15)

real    0m0.082s
user    0m0.064s
sys     0m0.014s

This is using node v4.3.2 (for compatibility reasons).

Any clues? Thanks!

The text was updated successfully, but these errors were encountered:

austinksmith · 2017-02-19T14:59:23Z

Interesting, I'll have to take a look at it here soon. The issue appears to be that Node doesn't like using self as a shortcut to the global scope, typically self.blah would be the same as global.blah or window.blah so node is doing something weird.

I'd suggest trying to use a 3rd party web worker implementation as well, something like this might help you get started before I can address this as its an issue with the legacy fallback mode that doesn't actually use threads. https://www.npmjs.com/package/webworker-threads

Node doesn't ship with a native web worker implementation out of the box so the library is defaulting to the fallback mode in your case. If you make use of a third party implementation be sure to import that BEFORE you import hamsters.

csterritt · 2017-02-19T16:36:07Z

Hey Austin! Thanks for looking at this... I'm not in a particular hurry right now, so I'll be interested to see what you find.

…

On Sun, Feb 19, 2017 at 9:59 AM, Austin Smith ***@***.***> wrote: Interesting, I'll have to take a look at it here soon. The issue appears to be that Node doesn't like using self as a shortcut to the global scope, typically self.blah would be the same as global.blah or window.blah so node is doing something weird. I'd suggest trying to use a 3rd party web worker implementation as well, something like this might help you get started before I can address this as its an issue with the legacy fallback mode that doesn't actually use threads. https://www.npmjs.com/package/webworker-threads Node doesn't ship with a native web worker implementation out of the box so the library is defaulting to the fallback mode in your case. If you make use of a third party implementation be sure to import that *BEFORE* you import hamsters. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACUHYscTUC5g4BoKx9J1y7FYf7O5M6lks5reFjLgaJpZM4MFKpC> .

austinksmith · 2017-02-19T17:01:06Z

@csterritt Try using the latest from dev branch now, just pushed this commit which should fix the issue. I haven't tested it yet but it looks like it'll work.

17b18ab

austinksmith · 2017-02-23T20:24:40Z

@csterritt Please let me know if that resolved your issue if you get the chance, thanks

csterritt · 2017-02-24T14:05:14Z

Hi Austin, Will do - it may be a week or so, I'm traveling now.

…

-- chris

On Feb 23, 2017, at 1:24 PM, Austin Smith ***@***.***> wrote: @csterritt Please let me know if that resolved your issue if you get the chance, thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

austinksmith · 2017-02-26T19:05:15Z

@csterritt No problem, I'm going to go ahead and close this issue out. I went ahead and published v3.9.8 which includes this fix. If you have anymore issues feel free to open another ticket, thanks!

https://github.com/austinksmith/Hamsters.js/releases/tag/v3.9.8

csterritt · 2017-03-01T22:02:31Z

Sorry to be 'that guy', but I'm getting a new problem with v3.9.8. It fails the same way under node v4.3.2 and v7.7.0:

/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:312
          hamsters.wheel.hamsters.push(new Worker('src/common/wheel.min.js'));
                                           ^

ReferenceError: Worker is not defined
    at spawnHamsters (/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:312:44)
    at /Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:963:7
    at setupHamstersEnvironment (/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:112:5)
    at /Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:907:3
    at Object.<anonymous> (/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:966:3)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

austinksmith · 2017-03-02T13:45:12Z

No problem, that's why I asked you to follow up haha. So it looks like I mixed up the order during the environment setup so currently the v3.9.8 will only work with a 3rd party web worker implementation (which is what you'll want for real threading). I'll push a fix today that will restore the legacy fallback mode which will allow you to write your logic and take advantage of the async nature of the library but will not give you the performance benefits you're probably looking for with extra threads.

austinksmith · 2017-03-02T14:12:35Z

As promised, this should resolve your issues. Runkit on npm hasn't updated yet but i think this will work.

https://github.com/austinksmith/Hamsters.js/releases/tag/v4.0.0

csterritt · 2017-03-03T22:08:42Z

Alas:

/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:102
      setupNodeSupport();
      ^

ReferenceError: setupNodeSupport is not defined
    at setupHamstersEnvironment (/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:102:7)
    at /Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:909:3
    at Object.<anonymous> (/Volumes/Second/Chris/myprogram/node_modules/hamsters.js/src/es5/hamsters.js:968:3)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Volumes/Second/Chris/myprogram/build/try-parallel.js:3:17)

Also, which 3rd party web worker implementation do you recommend?

austinksmith · 2017-03-07T01:17:14Z

Hmm, so I actually published version 4.0 which resolves the issue you're talking about already. I see on the npmjs.com page that it shows version 4.0 is what you should see. This however looks like version 3.9.9.

austinksmith · 2017-03-07T01:23:01Z

I put in a support ticket with them to get the website to update the package, sorry about that. Regarding web worker implementations, this one looks fairly good. I will warn however that their example documentation isn't what you probably want here. You'll probably need to do something like this.

require('webworker-threads');
require('hamsters.js');

Then you can just use Hamsters like you usually would. If you get an error that Worker doesn't exist..then do what their documentation says and assign a global variable to assign Worker.

global.Worker = require('webworker-threads').Worker;
require('hamsters.js');

csterritt · 2017-03-07T23:13:50Z

Hey Austin - glad to report that 4.0 works fine! I haven't gotten it working with webworker-thread yet, but I'm sure that will come.

Thanks again for your help!

austinksmith closed this as completed Feb 26, 2017

austinksmith reopened this Mar 7, 2017

csterritt closed this as completed Mar 7, 2017

austinksmith mentioned this issue May 1, 2017

Worker is not defined in Node v6 #27

Closed

austinksmith added resolved and removed resolved labels Feb 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Getting a failure under node #23

Getting a failure under node #23

csterritt commented Feb 18, 2017

austinksmith commented Feb 19, 2017

csterritt commented Feb 19, 2017 via email

austinksmith commented Feb 19, 2017

austinksmith commented Feb 23, 2017

csterritt commented Feb 24, 2017 via email

austinksmith commented Feb 26, 2017

csterritt commented Mar 1, 2017

austinksmith commented Mar 2, 2017

austinksmith commented Mar 2, 2017 •

edited

csterritt commented Mar 3, 2017

austinksmith commented Mar 7, 2017

austinksmith commented Mar 7, 2017 •

edited

csterritt commented Mar 7, 2017

Getting a failure under node #23

Getting a failure under node #23

Comments

csterritt commented Feb 18, 2017

austinksmith commented Feb 19, 2017

csterritt commented Feb 19, 2017 via email

austinksmith commented Feb 19, 2017

austinksmith commented Feb 23, 2017

csterritt commented Feb 24, 2017 via email

austinksmith commented Feb 26, 2017

csterritt commented Mar 1, 2017

austinksmith commented Mar 2, 2017

austinksmith commented Mar 2, 2017 • edited

csterritt commented Mar 3, 2017

austinksmith commented Mar 7, 2017

austinksmith commented Mar 7, 2017 • edited

csterritt commented Mar 7, 2017

austinksmith commented Mar 2, 2017 •

edited

austinksmith commented Mar 7, 2017 •

edited