Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show/Hide password icons interrupt input navigation #80

Closed
RDelorier opened this issue Aug 1, 2016 · 2 comments · Fixed by #88
Closed

Show/Hide password icons interrupt input navigation #80

RDelorier opened this issue Aug 1, 2016 · 2 comments · Fixed by #88

Comments

@RDelorier
Copy link
Contributor

Just finished setting up a site and noticed that tabbing through the password fields will stop on the show/hide icons. Should those links have tabindex -1 or is that intended?
@austintoddj
Copy link
Owner

Not intended. Just checked it in Safari and Chrome, and it appears to only affect Chrome. If you want to make a PR for it and Chrome/Firefox/Safari all work as expected, I'll merge it in right away. Good catch @RDelorier!

@austintoddj austintoddj added the bug label Aug 1, 2016
@RDelorier
Copy link
Contributor Author

Whew what a day, I'll get a PR open in just a few!

@RDelorier RDelorier mentioned this issue Aug 2, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable tab stop on password show/hide links RDelorier/Canvas
2 participants
@RDelorier @austintoddj