Fix using frames as a setter #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the frames didn't clear the raw data structure, meaning that the new value for frames would be mistakenly overwritten by the module incorrectly converting the raw data structure the first time frames were accessed even if they'd been manually set to some other value
|
This test failure is something wrong on one of the author tests on 5.10 (but not other Perls) |
|
I merged this from the CLI. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the frames didn't clear the raw data structure, meaning that the
new value for frames would be mistakenly overwritten by the module
incorrectly converting the raw data structure the first time frames
were accessed even if they'd been manually set to some other value