Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why subclass EventEmitter? #12

Closed
davidascher opened this issue May 24, 2017 · 3 comments
Closed

Why subclass EventEmitter? #12

davidascher opened this issue May 24, 2017 · 3 comments

Comments

@davidascher
Copy link

It's not clear to me from the code in Auth.js that it's using the subclassing of EventEmitter -- could it be that's not needed anymore? If so, happy to provide a PR to remove it and the dependency.
@chenkie
Copy link
Contributor

chenkie commented May 25, 2017

Looks like it's a carry-over from older samples. If you're up for making the changes that would be great :)

Thanks

@chenkie chenkie closed this as completed in 6e86376 Jun 2, 2017
@davidascher
Copy link
Author

ah, sorry, this dropped off my radar.

@chenkie
Copy link
Contributor

chenkie commented Jun 2, 2017

No prob! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidascher @chenkie