Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically building Auth0.swift causes URL handling to fail on iOS 10 device #228

Closed
joelk opened this issue Sep 26, 2018 · 8 comments
Closed

Comments

@joelk
Copy link

joelk commented Sep 26, 2018

On an iOS 10 device using universal login, I successfully signed in and receive a callback URL, but Auth0.resumeAuth() returns false for that URL. It turns out that when Auth0.swift is built statically (following the process in https://github.com/Carthage/Carthage/blob/master/Documentation/StaticFrameworks.md), the call to Auth0.resumeAuth() returns false. When we build the library as a dynamic framework, it works correctly.

This happens on every version of the library that we've tested, 1.10.0 through 1.13.0, on both devices and simulators running iOS 10.

See Auth0 support ticket #48169 for more details.

@cocojoe
Copy link
Member

cocojoe commented Sep 26, 2018

Thanks for reporting, will take a look 🤔

@cocojoe
Copy link
Member

cocojoe commented Oct 1, 2018

This is not something we officially support. As you noted there is no issue when used dynamically as per our supported installation method. However, logically I would like to think that a library if configured correctly with this method should behave the same.

You specifically mention iOS 10, does it work in iOS 9 or 11?

Have you made any changes to compiler settings such as changing the optimisation level?

@joelk
Copy link
Author

joelk commented Oct 1, 2018

Works on iOS 11, presumably because it uses SFAuthenticationSession. Haven't tried on iOS 9, as my app doesn't support it. No changes to anything in the project except as outlined in the referenced document.

@cocojoe
Copy link
Member

cocojoe commented Oct 1, 2018

Thanks, would you mind trying the .useLegacyAuthentication flag please. This will use SFSafariViewController under iOS 11.

@joelk
Copy link
Author

joelk commented Oct 1, 2018

You mean as a test? I’d prefer it remain working in the app I ship.

@cocojoe
Copy link
Member

cocojoe commented Oct 1, 2018

Yes as a test please.

@joelk
Copy link
Author

joelk commented Oct 1, 2018

I'm sorry, I can't easily do that. Since opening this ticket we've upgraded to Xcode 10, necessitating a completely new build process. Rolling back and running a new build on the old process would take me half a day.

@cocojoe
Copy link
Member

cocojoe commented Aug 8, 2019

Closing due to lack of activity.

@cocojoe cocojoe closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants