Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dxcdt 586 select multiple ids for delete resource #935

Merged
merged 24 commits into from
Dec 5, 2023

Conversation

m3talsmith
Copy link
Contributor

🔧 Changes

In all the auth0 * delete|rm commands, we should allow users to select more than one resource to delete to improve DX

📚 References

🔬 Testing

  • Manual integration testing
  • All unit tests are up to date
  • Batch delete commands are used in integration test cleanup

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

dependabot bot and others added 20 commits November 13, 2023 12:38
Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix: Remove or replace deprecations for GoReleaser config

Remove deprecated replacements
Replace deprecated brews tap
Replace deprecated scoop entries
Fix name_template to reflect exact current naming conventions

* DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

* Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…est token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

Title Os for final release name fit
Added batch deletion to actions command
Added batch deletion to apis command
Added batch deletion to apps command
Added batch deletion to custom domains command
Added batch deletion to log streams command
Added batch deletion for organizations command
Added batch deletion for roles command
Added batch deletion for rules command
Added batch deletion for users non-interactive command
Added batch deletion for user blocks non-interactive command
Update required golang minimum version
* Add ability to update signing alg for apis

* Removing short alias

---------

Co-authored-by: Will Vedder <will.vedder@okta.com>
…586-select-multiple-ids-for-delete-resource
Ensure valid id before deletion process
Normalize messages for deletion
Remove unnecessary path escapes
Continue on read failure instead of attempting delete
Inform user of failed id on batch deletion
Only document at most two ids likely
@m3talsmith m3talsmith requested a review from a team as a code owner December 5, 2023 17:36
@willvedd
Copy link
Contributor

willvedd commented Dec 5, 2023

Originally reviewed in #928 but re-opened because it was a fork and not allowing integration tests to run.

@m3talsmith m3talsmith force-pushed the DXCDT-586-select-multiple-ids-for-delete-resource branch from ae99ce0 to 3b4394d Compare December 5, 2023 17:43
@codecov-commenter
Copy link

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (3ea19cd) 72.32% compared to head (f24b664) 71.90%.

Files Patch % Lines
internal/cli/arguments.go 0.00% 16 Missing ⚠️
internal/cli/users_blocks.go 31.57% 13 Missing ⚠️
internal/cli/apps.go 52.63% 7 Missing and 2 partials ⚠️
internal/cli/input.go 0.00% 9 Missing ⚠️
internal/cli/users.go 52.63% 7 Missing and 2 partials ⚠️
internal/prompt/prompt.go 0.00% 9 Missing ⚠️
internal/cli/rules.go 57.89% 5 Missing and 3 partials ⚠️
internal/cli/apis.go 58.82% 5 Missing and 2 partials ⚠️
internal/cli/custom_domains.go 56.25% 5 Missing and 2 partials ⚠️
internal/cli/log_streams.go 58.82% 5 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   72.32%   71.90%   -0.42%     
==========================================
  Files          92       92              
  Lines       12503    12566      +63     
==========================================
- Hits         9043     9036       -7     
- Misses       2929     2990      +61     
- Partials      531      540       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m3talsmith m3talsmith merged commit dba337f into main Dec 5, 2023
8 checks passed
@m3talsmith m3talsmith deleted the DXCDT-586-select-multiple-ids-for-delete-resource branch December 5, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants