-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmark sandbox_version as readonly #683
Conversation
E2E tests failed. I saw errors and don't know why failed. Do I need to take any action? |
cc @willvedd |
@hmd34 I haven't forgotten about this. Can confirm that support for updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hmd34 thanks for your patience here. I needed to confirm that this property was configurable and can confirm. I went ahead and updated the test recordings to get this ready for approval.
Despite the CircleCI checks suggesting otherwise, all tests are indeed passing. My suspicion is that this fork's lack of environment variables being injected is interfering with the recordings. Going ahead with a merge anyway, we'll have to fix that integration later. |
@willvedd So sorry for delayed response and thank you for your work. |
🔧 Changes
Previously, there was a issue about sandbox_version Import. #69
So mark sandbox_version to readonly, and remove sandbox_version in export.
Now seems to have been resolved that issue. Fix so that sandbox_version is exported again.
📚 References
Fix: #682
🔬 Testing
Following steps
sandbox_version
in tenant.json📝 Checklist