Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom implementations of IBrowser being ignored by Auth0 Oidc for Android and iOS. #10

Closed
bruno-david opened this issue May 2, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@bruno-david
Copy link

On Android and iOS, Is there any specific reason for ignoring custom implementations of IBrowser on the Auth0Client class?

#if __IOS__
    RedirectUri = $"{Foundation.NSBundle.MainBundle.BundleIdentifier}://{options.Domain}/ios/{Foundation.NSBundle.MainBundle.BundleIdentifier}/callback",
    Browser = new PlatformWebView(options.Controller),
#elif __ANDROID__
    RedirectUri = options.RedirectUri ?? $"{packageName}://{options.Domain}/android/{packageName}/callback".ToLower(),
    Browser = new PlatformWebView(options.Activity),
@jerriep jerriep self-assigned this May 3, 2018
@jerriep jerriep added the bug label May 3, 2018
@jerriep
Copy link
Contributor

jerriep commented May 3, 2018

This is fixed in the upcoming V2:
https://github.com/auth0/auth0-oidc-client-net/blob/v2/src/Auth0.OidcClient.Shared/Auth0Client.cs#L40

At the time I think I did it because there were strict requirements on the constructor parameters being passed in (i.e. the Activity and UIViewController instances).

In any case, I am awaiting feedback from testers on V2, so, hopefully, it is not too far off anymore.

@jerriep jerriep added this to the v2.0.0 milestone May 3, 2018
@bruno-david
Copy link
Author

Ok, thanks for your response.
Do you have an estimated date on v2 release? Or is there any way to use the prerelease package in the meantime?

@jerriep
Copy link
Contributor

jerriep commented May 7, 2018

Nothing definite. It depends on the feedback I get. Hopefully, we can do it this month.

@jerriep jerriep modified the milestones: v2.0.0, v2.1.0 Jun 25, 2018
@jerriep
Copy link
Contributor

jerriep commented Jun 25, 2018

@badavid85 This was fixed in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants