Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncIO - Add asyncio support to JwksFetcher #432

Closed
ca-simone-chiorazzo opened this issue Sep 22, 2022 · 1 comment · Fixed by #445
Closed

AsyncIO - Add asyncio support to JwksFetcher #432

ca-simone-chiorazzo opened this issue Sep 22, 2022 · 1 comment · Fixed by #445
Labels
feature request A feature has been asked for or suggested by the community

Comments

@ca-simone-chiorazzo
Copy link

Describe the problem you'd like to have solved

You did a great job in adding asyncio support for the management and authentication clients.
In order to have completely asyncio approach, it would be great to have also an asyncio implementation for the JWKS fetcher.

As of today, such object is IO blocking and can block a python asyncio app for a while due to the download of a resource from internet.

Describe the ideal solution

Add an AsyncJWKSFetcher implementation that leverage aiohttp to execute HTTP calls

Alternatives and current work-arounds

Additional information, if any

@ca-simone-chiorazzo ca-simone-chiorazzo added the feature request A feature has been asked for or suggested by the community label Sep 22, 2022
@adamjmcgrath
Copy link
Contributor

Thanks for raising this @ca-simone-chiorazzo - will take a look at this and update you shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature has been asked for or suggested by the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants