Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints #470

Closed
Viicos opened this issue Jan 24, 2023 · 2 comments · Fixed by #497
Closed

Add type hints #470

Viicos opened this issue Jan 24, 2023 · 2 comments · Fixed by #497
Labels
feature request A feature has been asked for or suggested by the community

Comments

@Viicos
Copy link
Contributor

Viicos commented Jan 24, 2023

As the project is now supporting Python3.7 and greater, we could add type hints. I'd be happy to work on this if this is an option.

For reference: https://typing.readthedocs.io/en/latest/source/libraries.html

Tracked PRs:

@Viicos Viicos added the feature request A feature has been asked for or suggested by the community label Jan 24, 2023
@adamjmcgrath
Copy link
Contributor

Hi @Viicos - thanks for the offer

We'd be happy to look at a PR, we may choose to limit the completeness of the types depending on the maintenance overhead. (eg typing the arguments required for getting a client by id, great - typing the whole response payload for every request to the management api, not maintainable for us right now)

@Viicos
Copy link
Contributor Author

Viicos commented Jan 26, 2023

Yes this is understandable, I'll take a deep look at the repository and describe on this issue where I'll add types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature has been asked for or suggested by the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants