-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es-cookie is breaking CJS versions #964
Comments
Author of es-cookie here. I suppose auth0-spa-js could also pin I'm surprised there are still many CJS-only projects, though. It seems like that would be increasingly limiting as more and more libraries are designed for ESM from the start. |
One of the reasons is that I am not smart enough to get ESM packages working with Jest + Typescript |
96% of the packages in the npm registry, to be more precise. ESM including dual CJS/ESM is today at 4%. |
Thanks for raising this. I have pinned es-cookie to the latest patch versions only. |
Should be fixed as part of |
Describe the problem
auth0-spa-js depends on es-cookie, which has recently gone ESM only, and done it as a minor version. This is breaking CJS projects using auth0-spa-js.
In our case, this is a Jest test that's failing on unknown token export.
Auth0 should look to move off this library to maintain CJS support.
Reproduction
https://github.com/benjervis/auth0-escookie-issue
Environment
auth0-spa-js
used: 1.22.2The text was updated successfully, but these errors were encountered: