You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems very much out of scope to me. While it's nice to show how you can achieve this, it shouldn't be a dependency of express-jwt. Developers can install express-unless separately if they want it. For everyone else, it's just unnecessary additional files.
Maybe worth consideration to remove it for v3?
The text was updated successfully, but these errors were encountered:
We want to allow developers to easily exclude some routes and express-unless is the way we are doing that.
It's only a couple of files (it's not like these are being sent to a browser and we want to decrease download transfer time, it's just a few bytes when doing npm i and might make your app package a couple of KB bigger) and saves the small trouble of having to set it up with express-jet for developers who want to use it.
Seems very much out of scope to me. While it's nice to show how you can achieve this, it shouldn't be a dependency of express-jwt. Developers can install express-unless separately if they want it. For everyone else, it's just unnecessary additional files.
Maybe worth consideration to remove it for v3?
The text was updated successfully, but these errors were encountered: