Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make express-unless optional #65

Closed
billinghamj opened this issue Mar 27, 2015 · 1 comment
Closed

Make express-unless optional #65

billinghamj opened this issue Mar 27, 2015 · 1 comment

Comments

@billinghamj
Copy link

Seems very much out of scope to me. While it's nice to show how you can achieve this, it shouldn't be a dependency of express-jwt. Developers can install express-unless separately if they want it. For everyone else, it's just unnecessary additional files.

Maybe worth consideration to remove it for v3?

@dschenkelman
Copy link
Member

Hey @billinghamj,

Thanks for the feedback!

We want to allow developers to easily exclude some routes and express-unless is the way we are doing that.

It's only a couple of files (it's not like these are being sent to a browser and we want to decrease download transfer time, it's just a few bytes when doing npm i and might make your app package a couple of KB bigger) and saves the small trouble of having to set it up with express-jet for developers who want to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants