Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add Laravel 6 support #138

Closed
FreekVR opened this issue Sep 10, 2019 · 6 comments
Closed

Feature request: Add Laravel 6 support #138

FreekVR opened this issue Sep 10, 2019 · 6 comments
Milestone

Comments

@FreekVR
Copy link
Contributor

FreekVR commented Sep 10, 2019

Hi!

Laravel 6 was released a few days ago, but since they switched to semver, laravel-auth0 isn't installable as it needs to indicate compatibility in the composer.json

I've done some testing yesterday on a fork where I only changed the composer.json, and all functionality seemed to be fine, a quick scan of the codebase also didn't turn up any things that should be changed according to the laravel ugprade guide.

I'll submit a PR to make this package compatible, but please let me know if there's anything I missed.

@joshcanhelp
Copy link
Contributor

@FreekVR - Thank you for the report here! We have someone internally testing this as well and will merge your PR #139 when that's complete.

@carnevalle
Copy link
Contributor

@joshcanhelp any status on the testing and merging of this PR? It would be awesome to upgrade

@joshcanhelp
Copy link
Contributor

@carnevalle - I'll get this out first thing next week. First round of internal testing is complete, just want to make sure we cover as many use cases as we can 👍

@joshcanhelp joshcanhelp added this to the 5.3.0 milestone Sep 16, 2019
@giannidhooge
Copy link
Contributor

@joshcanhelp Any idea when 5.3.0 will be tagged?

@joshcanhelp
Copy link
Contributor

@giannidhooge - Thanks for checking in. I'm just waiting to see if we can get #135 in without breaking changes and we'll get that release cut. Appreciate your patience!

@joshcanhelp
Copy link
Contributor

5.3.0 is released with Laravel 6 support and fixed sessions! 🎉

https://github.com/auth0/laravel-auth0/releases/tag/5.3.0
https://packagist.org/packages/auth0/login#5.3.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants