Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM] version 1.5.1 is broken #97

Closed
enzocano opened this issue May 22, 2019 · 5 comments
Closed

[NPM] version 1.5.1 is broken #97

enzocano opened this issue May 22, 2019 · 5 comments
Labels
closed:stale Issue or PR has not seen activity recently

Comments

@enzocano
Copy link

Hi, I recently tried to use the latest version 1.5.1 in a TypeScript project and it seems like it's broken. In typescript, it doesn't resolve dependencies like express-jwt.

Also, if I try to download the package using npm pack jwks-rsa I got the following message:

npm notice === Tarball Details ===
npm notice name:          jwks-rsa
npm notice version:       1.5.1
npm notice filename:      jwks-rsa-1.5.1.tgz
npm notice package size:  2.8 MB
npm notice unpacked size: 10.6 MB
npm notice shasum:        05b7f1ba4e9829162e2aa3ab6a79d539416de200
npm notice integrity:     sha512-FcH0mrrfS/5CD[...]Pme4fb/ZoHKqQ==
npm notice total files:   2014
npm notice
jwks-rsa-1.5.1.tgz
@ottokruse
Copy link

I have the same issue

@oros
Copy link

oros commented May 27, 2019

Looks related: 98c1c6c

Temporary working around by including the dev dependency explicitly.

@Brunomachadob
Copy link

Yep, seems to be related to that commit.
We are having the same problem here.

@ottokruse
Copy link

It of course makes sense that express-jwt is not a dependency for people that want to use node-jwks-rsa without express (me). But then the typings shouldn't depend on it :)

@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Oct 26, 2019
@stale stale bot closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:stale Issue or PR has not seen activity recently
Projects
None yet
Development

No branches or pull requests

4 participants