Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove vulnerable node-saml dependency #126

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

david-renaud-okta
Copy link
Contributor

@david-renaud-okta david-renaud-okta commented Feb 7, 2022

Description

Updated saml to version 2.0.0

BREAKING CHANGE: Requires NodeJS >= 12

References

https://github.com/auth0/node-saml/releases/tag/v2.0.0

Testing

All existing tests pass

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

CharlesRea
CharlesRea previously approved these changes Feb 7, 2022
Copy link

@CharlesRea CharlesRea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@david-renaud-okta
Copy link
Contributor Author

Updated node-saml to v2.0.1 to include additional fixes (https://github.com/auth0/node-saml/releases/tag/v2.0.1)

@david-renaud-okta david-renaud-okta merged commit bab5bd0 into master Feb 9, 2022
@david-renaud-okta david-renaud-okta deleted the IPS-2350 branch February 9, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants