Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML XML is always parsed assuming utf-8 encoding #60

Open
ziluvatar opened this issue Sep 28, 2017 · 0 comments
Open

SAML XML is always parsed assuming utf-8 encoding #60

ziluvatar opened this issue Sep 28, 2017 · 0 comments

Comments

@ziluvatar
Copy link
Contributor

While reading the SAMLRequest the library converts the base64 string to a Buffer, after that it converts whether to a string without considering if the XML defined a different encoding in the prolog:

<?xml version="1.0" encoding="UTF-8" ?> <== usually UTF-8 is used, in some cases it can contain a different encoding. We should read the rest of XML based on that encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant