Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State shouldn't be required #66

Closed
MarkPfennig opened this issue May 20, 2015 · 2 comments
Closed

State shouldn't be required #66

MarkPfennig opened this issue May 20, 2015 · 2 comments

Comments

@MarkPfennig
Copy link

$state = $wp_query->query_vars['state'];
...
if ($stateFromGet->interim) {

Lines 344 & 392

This assumes state is present, and assumes that it's a json_encoded object that always has an interim property. Due to this it throws PHP notices which if displayed prevent auth0 from redirecting.

State isn't always present, like when doing sso via /authorize.

Just use isset checks and it'll fix the problem :)

Thanks

@glena
Copy link
Contributor

glena commented May 20, 2015

Sure, I will make a release fixing that by today

@glena
Copy link
Contributor

glena commented May 21, 2015

This is fixes on the version 1.2.4 of the plugin. Will be ready to update in a minutes.

@glena glena closed this as completed May 21, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants