Switching wizard admin user creation to use /dbconnections/signup #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
approved these changes
Jan 8, 2018
| 'email' => $current_user->user_email, | ||
| 'password' => $_POST['admin-password'], | ||
| 'connection' => $db_connection_name, | ||
| 'email_verified' => true |
There was a problem hiding this comment.
So it seems there is a change in behaviour here as the user will need to manually verify their email. I am okay with this.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing dev, @cocojoe and I found that the /api/v2/users endpoint used in
WP_Auth0_Api_Client::create_userwould not authenticate because the API Client being used was not being activated by default for the Database Connection that was being made. We created a new method,WP_Auth0_Api_Client::signup_userto use the Authentication signup endpoint.