Fixed Client Grant Types during update #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 17 to attempt to update existing grant_types; better banner verbiage and error log handling for the update
joshcanhelp
changed the title
glena
approved these changes
Jan 26, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older legacy clients may not have the
client_credentialsGrant Type activated in their Client Advanced settings. This will prevent them from getting a Management API token, breaking functionality in a number of places. This can be remedied manually in Client Advanced Settings > Grant Types tab, activating the Client Credentials type.This PR adds a DB version and attempts to update this automatically if there is a valid API token saved in wp-admin. It also enforces the correct
grant_typesduring client creation and adds a note to the README and CHANGELOG regarding the 3.5.0 update.