Change asset enqueuing #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshcanhelp
commented
Mar 27, 2018
•
joshcanhelp
commented
- Move asset URLs to constants
- Combine multiple instances of scripts and styles being enqueued in the admin to one place
- Combine multiple instances of Lock URLs to one place
joshcanhelp
force-pushed
the
change-script-enqueue
branch
from
20940aa
to
0e3a49e
Compare
joshcanhelp
commented
Mar 28, 2018
| } | ||
|
|
||
| public function shortcode( $atts ) { | ||
| wp_enqueue_script( 'jquery' ); | ||
|
|
||
| if ( WP_Auth0_Options::Instance()->get('passwordless_enabled') ) { |
There was a problem hiding this comment.
Moved to templates/login-form.php
joshcanhelp
commented
Mar 28, 2018
|
|
||
| wp_enqueue_script( 'jquery' ); | ||
|
|
||
| if ( WP_Auth0_Options::Instance()->get('passwordless_enabled') ) { |
There was a problem hiding this comment.
Moved to templates/login-form.php
joshcanhelp
commented
Mar 28, 2018
|
|
||
| if ( trim( $client_id ) !== '' ) { | ||
|
|
||
| if ( WP_Auth0_Options::Instance()->get( 'passwordless_enabled' ) ) { |
There was a problem hiding this comment.
Moved to templates/login-form.php
joshcanhelp
force-pushed
the
change-script-enqueue
branch
from
0e3a49e
to
3d9d42c
Compare
joshcanhelp
commented
Mar 28, 2018
| @@ -31,12 +31,6 @@ public function show_error() { | |||
|
|
|||
| public function render_import_settings_page() { | |||
|
|
|||
| wp_enqueue_media(); | |||
There was a problem hiding this comment.
Moved to lib/admin/WP_Auth0_Admin.php
joshcanhelp
force-pushed
the
change-script-enqueue
branch
from
3d9d42c
to
ee9c038
Compare
joshcanhelp
force-pushed
the
change-script-enqueue
branch
5 times, most recently
from
89e7416
to
07cc0ab
Compare
Non-breaking change to centralize asset URLs and remove duplication
joshcanhelp
force-pushed
the
change-script-enqueue
branch
from
07cc0ab
to
979bfc6
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.