Add /userinfo fallback during login #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Mar 29, 2018
| @@ -19,9 +19,12 @@ public static function insert_auth0_error( $section, $error ) { | |||
| } elseif ( $error instanceof Exception ) { | |||
| $code = $error->getCode(); | |||
| $message = $error->getMessage(); | |||
| } elseif ( is_array( $error ) && ! empty( $error['response'] ) ) { | |||
There was a problem hiding this comment.
Typical response from wp_remote_post() and wp_remote_get()
joshcanhelp
force-pushed
the
add-userinfo-fallback
branch
from
7750c08
to
dc1cdc2
Compare
|
Addresses #401 |
cocojoe
reviewed
Apr 4, 2018
lib/WP_Auth0_Lock10_Options.php
Outdated
| protected $signup_mode = false; | ||
| protected $_id_token_scopes = 'openid email email_verified name nickname picture'; |
There was a problem hiding this comment.
why id_token_scopes btw and not just scopes?
| $userinfo_resp_body = wp_remote_retrieve_body( $userinfo_resp ); | ||
|
|
||
| // Management API call failed | ||
| // Management API call failed, fallback to userinfo |
There was a problem hiding this comment.
So why does Management API fail?
There was a problem hiding this comment.
This is something we should have had in 3.5.0. It will fail if the Client/Application is not authorized on the Management API or if Client Grant has not been turned on. Has been a common support theme and wanted to get it in there for anyone else upgrading.
joshcanhelp
force-pushed
the
add-userinfo-fallback
branch
from
dc1cdc2
to
192a388
Compare
lbalmaceda
reviewed
Apr 10, 2018
lib/WP_Auth0_ErrorManager.php
Outdated
| @@ -19,9 +19,12 @@ public static function insert_auth0_error( $section, $error ) { | |||
| } elseif ( $error instanceof Exception ) { | |||
| $code = $error->getCode(); | |||
| $message = $error->getMessage(); | |||
| } elseif ( is_array( $error ) && ! empty( $error['response'] ) ) { | |||
| $code = ! empty( $error['response']['code'] ) ? $error['response']['code'] : 'N/A'; | |||
There was a problem hiding this comment.
Instead of N/A use something like a0_unknown_code or if you received a "plain text response" then use that as description and use some code like a0_plaintext_error
lbalmaceda
reviewed
Apr 10, 2018
lib/WP_Auth0_ErrorManager.php
Outdated
| @@ -19,9 +19,12 @@ public static function insert_auth0_error( $section, $error ) { | |||
| } elseif ( $error instanceof Exception ) { | |||
| $code = $error->getCode(); | |||
| $message = $error->getMessage(); | |||
| } elseif ( is_array( $error ) && ! empty( $error['response'] ) ) { | |||
| $code = ! empty( $error['response']['code'] ) ? $error['response']['code'] : 'N/A'; | |||
| $message = ! empty( $error['response']['message'] ) ? $error['response']['message'] : 'N/A'; | |||
There was a problem hiding this comment.
this one is fine, it makes sense.
lbalmaceda
suggested changes
Apr 10, 2018
lib/WP_Auth0_Lock10_Options.php
Outdated
| protected $signup_mode = false; | ||
| protected $_scopes = 'openid email email_verified name nickname picture'; |
There was a problem hiding this comment.
email_verified included in email
lib/WP_Auth0_Lock_Options.php
Outdated
| protected $signup_mode = false; | ||
| protected $_id_token_scopes = 'openid email email_verified name nickname picture'; |
| @@ -245,30 +244,29 @@ public function redirect_login() { | |||
|
|
|||
| // Attempt to authenticate with the Management API | |||
| $client_credentials_token = WP_Auth0_Api_Client::get_client_token(); | |||
| $userinfo_resp = null; | |||
| $userinfo_resp_code = $userinfo_resp_body = null; | |||
There was a problem hiding this comment.
what's this 2 = assignment?
There was a problem hiding this comment.
Equivalent to:
$userinfo_resp_code = null;
$userinfo_resp_body = null;
9850da0
to
c721384
Compare
Some customers are having trouble with the upgrade process in 3.5.2 while others made make changes to their account disabling management API access. This fallback allows user data to be pulled for logging-in users. Also adds requested scopes for auth code login to make this possible.
joshcanhelp
force-pushed
the
add-userinfo-fallback
branch
from
c721384
to
4d00d5e
Compare
lbalmaceda
approved these changes
Apr 12, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some customers are having trouble with the upgrade process in 3.5.2 while others made make changes to their account disabling management API access. This fallback allows user data to be pulled for logging-in users. Also adds requested scopes for auth code login to make this possible and updates the error manager class to handle a common error case.