Deprecating unused Lock Options classes and methods #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshcanhelp
commented
Apr 23, 2018
joshcanhelp
commented
- WP_Auth0_Lock_Options class
- WP_Auth0_Lock10_Options::get_lock_classname()
- WP_Auth0_Lock10_Options::isPasswordlessEnable()
- WP_Auth0_Lock10_Options::get_lock_show_method()
- WP_Auth0_Lock10_Options::get_custom_css()
- WP_Auth0_Lock10_Options::get_custom_js()
- WP_Auth0_Lock10_Options::can_show()
- WP_Auth0_Lock10_Options::get_cdn_url()
- WP_Auth0_Lock10_Options::get_wordpress_login_enabled()
- WP_Auth0_Lock10_Options::set_signup_mode()
- WP_Auth0_Lock10_Options::modal_button_name()
- WP_Auth0_Lock10_Options::get_custom_signup_fields()
- WP_Auth0_Lock10_Options::has_custom_signup_fields()
lbalmaceda
reviewed
Apr 25, 2018
lib/WP_Auth0_Lock10_Options.php
Outdated
| if ( $this->_get_boolean( $this->wp_options->get( 'passwordless_enabled' ) ) ) { | ||
| return 'Auth0LockPasswordless'; | ||
| } else { | ||
| return 'Auth0Lock'; | ||
| } | ||
| } | ||
|
|
||
| // TODO: Deprecate - specific templates choose passwordless or not | ||
| /** | ||
| * @deprecated 3.6.0 - Not used |
lib/WP_Auth0_Lock10_Options.php
Outdated
| * @deprecated 3.6.0 - Not used | ||
| * | ||
| * @return bool | ||
| */ | ||
| public function isPasswordlessEnable() { |
There was a problem hiding this comment.
typo on this function name? 🤔 hehe
lib/WP_Auth0_Lock10_Options.php
Outdated
| return $this->_get_boolean( $this->wp_options->get( 'wordpress_login_enabled' ) ); | ||
| } | ||
|
|
||
| public function get_auth0_implicit_workflow() { | ||
| return $this->_get_boolean( $this->wp_options->get( 'auth0_implicit_workflow' ) ); | ||
| } | ||
|
|
||
| /** | ||
| * @deprecated 3.6.0 - Not used |
lib/WP_Auth0_Lock10_Options.php
Outdated
| @@ -93,7 +153,14 @@ public function show_as_modal() { | |||
| return isset( $this->extended_settings['show_as_modal'] ) && $this->extended_settings['show_as_modal']; | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated 3.6.0 - Not used | |||
lib/WP_Auth0_Lock10_Options.php
Outdated
| @@ -183,7 +250,14 @@ protected function build_settings( $settings ) { | |||
| return $options_obj; | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated 3.6.0 - Not used | |||
lib/WP_Auth0_Lock10_Options.php
Outdated
| @@ -192,7 +266,15 @@ public function get_custom_signup_fields() { | |||
|
|
|||
| return $fields; | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated 3.6.0 - Not used | |||
- WP_Auth0_Lock_Options class - WP_Auth0_Lock10_Options::get_lock_classname() - WP_Auth0_Lock10_Options::isPasswordlessEnable() - WP_Auth0_Lock10_Options::get_lock_show_method() - WP_Auth0_Lock10_Options::get_custom_css() - WP_Auth0_Lock10_Options::get_custom_js() - WP_Auth0_Lock10_Options::can_show() - WP_Auth0_Lock10_Options::get_cdn_url() - WP_Auth0_Lock10_Options::get_wordpress_login_enabled() - WP_Auth0_Lock10_Options::set_signup_mode() - WP_Auth0_Lock10_Options::modal_button_name() - WP_Auth0_Lock10_Options::get_custom_signup_fields() - WP_Auth0_Lock10_Options::has_custom_signup_fields()
joshcanhelp
force-pushed
the
deprecate-lock-options
branch
from
7daf441
to
f5b1d9a
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.