Deprecate 2 lookup methods #446
Conversation
joshcanhelp
commented
Apr 23, 2018
joshcanhelp
commented
- WP_Auth0_Options::get_enabled_connections()
- WP_Auth0::get_plugin_dir_url()
lib/WP_Auth0_Options.php
Outdated
| @@ -19,8 +19,13 @@ public function is_wp_registration_enabled() { | |||
| return get_site_option( 'users_can_register', 0 ) == 1; | |||
| } | |||
|
|
|||
| // TODO: Deprecate, not used | |||
| /** | |||
| * @deprecated 3.6.0 - Not used | |||
|
@lbalmaceda - beautification is a bit of a WIP but I will be running the whitespace one once all the PRs are in place. |
joshcanhelp
force-pushed
the
deprecate-lookup-methods
branch
from
1b96d10
to
78ac6cc
Compare
- WP_Auth0_Options::get_enabled_connections() - WP_Auth0::get_plugin_dir_url()
joshcanhelp
force-pushed
the
deprecate-lookup-methods
branch
from
78ac6cc
to
4bac657
Compare
| public function get_enabled_connections() { | ||
| // phpcs:ignore | ||
| trigger_error( sprintf( __( 'Method %s is deprecated.', 'wp-auth0' ), __METHOD__ ), E_USER_DEPRECATED ); | ||
| return array( 'facebook', 'twitter', 'google-oauth2' ); |
There was a problem hiding this comment.
is weird that this was (and is) hardcoding an array of enabled connections. I've read the deprecation message. However, are you currently calling this method somewhere in your plugin?
There was a problem hiding this comment.
I didn't remove it so I'm not entirely sure when or where this was used. I checked through all the functions here and did not see it used anywhere in the code. I think this was part of the initial setup at some point?
This is the case with a number of this deprecations. I didn't remove them and didn't see them used anywhere. If we're not using the method internally, I don't want to maintain it 👍
