Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing suite, initial tests, and CircleCI #503

Merged
merged 7 commits into from
Jul 20, 2018
Merged

Add testing suite, initial tests, and CircleCI #503

merged 7 commits into from
Jul 20, 2018

Conversation

joshcanhelp
Copy link
Contributor

  • Ran wp scaffold plugin-tests auth0 --ci=circle to add suite
  • Add initial tests in testWPAuth0Options

@joshcanhelp joshcanhelp added this to the v3-Next milestone Jul 19, 2018
joshcanhelp
joshcanhelp commented Jul 19, 2018
View reviewed changes
bin/install-wp-tests.sh
@@ -0,0 +1,152 @@
#!/usr/bin/env bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boilerplate from https://developer.wordpress.org/cli/commands/scaffold/plugin-tests/

joshcanhelp
joshcanhelp commented Jul 19, 2018
View reviewed changes
circle.yml
@@ -0,0 +1,47 @@
machine:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boilerplate from https://developer.wordpress.org/cli/commands/scaffold/plugin-tests/

joshcanhelp
joshcanhelp commented Jul 19, 2018
View reviewed changes
tests/bootstrap.php
@@ -0,0 +1,31 @@
<?php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boilerplate from https://developer.wordpress.org/cli/commands/scaffold/plugin-tests/

@cocojoe
Copy link
Member

cocojoe commented Jul 20, 2018

So this is cool, I took the liberty of fixing the phpcs CLI arguments. Although now you have 1000+ errors 😆 to fix, so you should do a sniffer patch sometime that addresses all of this.
I've enabled the CI to this repo for dev branch.

@joshcanhelp
Copy link
Contributor Author

Thanks @cocojoe!

It occurs to me that I didn't want to run the pull phpcs command on PRs quite yet. As you saw, there are still a ton of issues to fix. I'll push a change for that.

cocojoe
cocojoe approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see some tests 👍

@joshcanhelp joshcanhelp merged commit 9699d77 into dev Jul 20, 2018
@joshcanhelp joshcanhelp deleted the add-testing-suite branch July 20, 2018 15:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @cocojoe